• Tobias Tebbi's avatar
    [torque] avoid ambiguity if a catch catches from other handlers · 7e7b24eb
    Tobias Tebbi authored
    Torque desugars try-catch/label constructs with several handlers
    into nested try structures, with the first handler ending-up
    innermost. So currently, if you write
    
    try {
    ...
    } label Foo {
      Throw(...);
    } catch (e) {
    
    }
    
    The catch will catch the preceding Throw in another handler.
    This is different from how multiple try-catch handlers are done in
    languages like Java, where throwing from a preceding catch handler
    is not caught by a later one. To avoid this possible ambiguity, this
    CL prohibits this pattern, enforcing that a catch handler comes first,
    before any other label-handler attached to the same try.
    This way, a catch handler never catches from any other handler on the
    same try, since they have to come later.
    
    Bug: v8:7793
    Change-Id: I943f14b2393d307c4254a3fc3a78f236dbcf86df
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2169098
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67516}
    7e7b24eb
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...