• Yang Guo's avatar
    Make termination exception more consistent. · 7e5cac2c
    Yang Guo authored
    Termination exceptions tear down V8 to the bottom-most V8 call. If there is a
    v8::TryCatch scope around that call, it returns true for HasTerminated() and
    HasCaught(). However, Isolate::IsExecutionTerminating() returns false and we
    can call into V8 from still inside the v8::TryCatch scope.
    
    Changes that this patch introduces:
     - You need to leave the v8::TryCatch scope around the bottom-most call to
       reset the termination state, in order to resume.
     - Explicitly check for termination exception and reporting it through the
       DevTools protocol after Runtime.evaluate and Debugger.evaluateOnCallFrame.
    
    Bug: v8:8455
    Change-Id: I1f36f7a365985469813c2619bf16f18ee69aa4b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1337582Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57963}
    7e5cac2c
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...