• Simon Zünd's avatar
    [deoptimizer] Handle continuation frames that are not preceded by adapter frames · 7e0f961e
    Simon Zünd authored
    This CL teaches the deoptimizer about JavaScriptBuiltinContinuation
    frames that are not preceded by argument adapter frames. This pattern
    is used when calling C++ API functions from TurboFan.
    
    This CL fixes a crash when the deoptimizer encounters the pattern
    described above. The crash was caused when the deoptimizer tried to
    read the arguments of the continuation frame. As no adapter frame
    was present, the argument count was read from the SharedFunctionInfo
    which had the kDontAdaptArgumentsSentinel value. This translated to
    an argument count of ~65000 later down the line, which caused a
    FATAL error when the deoptimizer tried to re-construct ~65000
    non-existent values.
    
    Bug: chromium:980529
    Change-Id: Id2de3bf7607102ab5a16de344c649015e968b185
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687417Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62547}
    7e0f961e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...