• Simon Zünd's avatar
    [deoptimizer] Handle continuation frames that are not preceded by adapter frames · 7e0f961e
    Simon Zünd authored
    This CL teaches the deoptimizer about JavaScriptBuiltinContinuation
    frames that are not preceded by argument adapter frames. This pattern
    is used when calling C++ API functions from TurboFan.
    
    This CL fixes a crash when the deoptimizer encounters the pattern
    described above. The crash was caused when the deoptimizer tried to
    read the arguments of the continuation frame. As no adapter frame
    was present, the argument count was read from the SharedFunctionInfo
    which had the kDontAdaptArgumentsSentinel value. This translated to
    an argument count of ~65000 later down the line, which caused a
    FATAL error when the deoptimizer tried to re-construct ~65000
    non-existent values.
    
    Bug: chromium:980529
    Change-Id: Id2de3bf7607102ab5a16de344c649015e968b185
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687417Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62547}
    7e0f961e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...