• marja's avatar
    Revert of Preparse inner functions. (patchset #23 id:440001 of... · 7de8639e
    marja authored
    Revert of Preparse inner functions. (patchset #23 id:440001 of https://codereview.chromium.org/2322243002/ )
    
    Reason for revert:
    This approach is not good - breaks when we recompile.
    
    Original issue's description:
    > Preparse inner functions.
    >
    > This is an overly pessimistic approach where PreParser only keeps
    > track of unresolved variables, but doesn't declare anything. This
    > will result in context-allocating variables in the outer function
    > unnecessarily, if the variable names clash with variable names
    > used by the inner function (even if the variables are not the
    > same). However, we have been unable to prove that this approach
    > wouldn't be good enough for the practical purposes.
    >
    > Committed: https://crrev.com/e1341ca8fa486bb2c9e4236672a64ec7756a164d
    > Cr-Commit-Position: refs/heads/master@{#39469}
    
    TBR=adamk@chromium.org,vogelheim@chromium.org,nikolaos@chromium.org,nednguyen@google.com
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/2349473004
    Cr-Commit-Position: refs/heads/master@{#39471}
    7de8639e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...