• Peter Marshall's avatar
    [logger] Start cleaning up Logger class · 7da7c0bd
    Peter Marshall authored
    - Use unique ptrs for owned objects
    - Remove friendship with CpuProfiler and replace with public API
    - Remove unused method LogFailure()
    - Remove StopProfiler() which was only used by LogFailure() (removed)
      and one test, which can use StopProfilerThread() instead
    - Remove 'paused' state which was only used by the above
    - Remove 'engage' state. There is no reason we need this as along as
      users keep track of Engage/Disengage calls
    
    Drive-by cleanup:
    - Remove import of log.h from profile-generator.h
    - Remove unnecessary includes of log.h
    
    Change-Id: Ifc4ca156bef038c40953f8361ffea17788e3a59b
    Reviewed-on: https://chromium-review.googlesource.com/c/1424338
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58957}
    7da7c0bd
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...