• Zhi An Ng's avatar
    [wasm-simd][x64] Optimize integer splats of constant 0 · 7d7b25d9
    Zhi An Ng authored
    Integer splats (especially for sizes < 32-bits) does not directly
    translate to a single instruction on x64. We can do better for special
    values, like 0, which can be lowered to `xor dst dst`. We do this check
    in the instruction selector, and emit a special opcode kX64S128Zero.
    
    Also change the xor operation for kX64S128Zero from xorps to pxor. This
    can help reduce any potential data bypass delay (search for this on
    agner's microarchitecture manual for more details.). Since integer
    splats are likely to be followed by integer ops, we should remain in the
    integer domain, thus use pxor.
    
    For i64x2.splat the codegen goes from:
    
      xorl rdi,rdi
      vmovq xmm0,rdi
      vmovddup xmm0,xmm0
    
    to:
    
      vpxor xmm0,xmm0,xmm0
    
    Also add a unittest to verify this optimization, and necessary
    raw-assembler methods for the test.
    
    Bug: v8:11093
    Change-Id: I26b092032b6e672f1d5d26e35d79578ebe591cfe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2516299Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70977}
    7d7b25d9
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...