• Ng Zhi An's avatar
    [wasm-simd][arm64][arm] Fix v128.const · 7c10560d
    Ng Zhi An authored
    There is a sign-extension bug happening when packing 2 32-bit ints into
    a 64-bit int. We are OR-ing int32_t with a uint64_t, so an integral
    conversion converts int32_t to uint64_t, which is a sign extension, and
    this gives unexpected results for a negative value:
    
        0x80000000 | uint64_t{0} -> 0xffffffff80000000
    
    What we want is 0x0000000080000000.
    
    Created a helper function to do this work of combining two uint32_t
    into one uint64_t. The use of this function will also ensure that
    if callers passed a int32_t, it would first be converted to a
    uint32_t, and will not have this sign extension bug.
    
    Sneaked a small regression test into the existing v128.const cctest,
    and also cleanup the loop to reset `expected` array to 0.
    
    Bug: chromium:1104033
    Change-Id: Icaca4c5ba42077dd4463697b9220cdbca9974b5e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2293044
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68850}
    7c10560d
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...