• Mythri A's avatar
    Reset optimization markers on OSR if function has insufficient feedback · 7c0e2003
    Mythri A authored
    With lazy feedback allocation, we don't have feedback vectors when function
    starts executing. If we mark the function on the first execution we would
    be missing feedback for the initial part of the function and hence the
    optimized code will not be useful.
    
    This cl resets the optimization markers on OSR if the invocation count of
    the function is less than 1. We may still do wasted optimizations if the
    function is hot enough for optimizing but not for OSRing. In the long term
    we may want to fix it differently. This fix covers the most common cases
    in benchmarks.
    
    Bug: chromium:987523
    Change-Id: I1cfe82e6b9f95278b77c99b77d4b981828b5c0ab
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1739373
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63124}
    7c0e2003
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...