• Andreas Haas's avatar
    Revert "[refactoring] Remove the isolate from signatures of ExternalReferences" · 7bfed2ad
    Andreas Haas authored
    This reverts commit 44ea425a.
    
    Reason for revert: https://ci.chromium.org/buildbot/client.v8.ports/V8%20Arm%20-%20debug%20builder/13575
    
    Original change's description:
    > [refactoring] Remove the isolate from signatures of ExternalReferences
    > 
    > In this CL I remove the isolate from signatures of ExternalReference
    > accessor functions where the isolate is not used. The uses of the
    > isolate were already removed in previous CLs.
    > 
    > Changes:
    > * I split the ExternalReference list in external-reference.h into
    > those which need the isolate for initialization and those which do not.
    > 
    > * I removed the public constructors and replaced them by
    >   ExternalReference::Create(). The reason is to separate external
    >   creation more clearly from internal creation, because externally
    >   created ExternalReferences sometimes need redirection, whereas
    >   internally created ExternalReferences are just stored as they are.
    >   In addition, by removing the isolate from the signature of the
    >   public constructors, they suddenly exactly matched the interal
    >   constructor.
    > 
    > * Replace all uses of the public constructors with
    >   ExternalReference::Create().
    > 
    > * Remove the isolate from all call sites where necessary.
    > 
    > 
    > This is a step towards making WebAssembly compilation independent of
    > the isolate.
    > 
    > Bug: v8:7570
    > R=​mstarzinger@chromium.org
    > 
    > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    > Change-Id: I14f511fc6acc50ab2d6a6641299f5ddbeabef0da
    > Reviewed-on: https://chromium-review.googlesource.com/1018982
    > Commit-Queue: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#52768}
    
    TBR=mstarzinger@chromium.org,ahaas@chromium.org
    
    Change-Id: I7c0d8d420f815cede23d550dee8942ac4d7791cc
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7570
    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/1026570Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52769}
    7bfed2ad
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...