• Leszek Swirski's avatar
    [turbofan] Use receiver maps for Array#push reduction · 7bf63faf
    Leszek Swirski authored
    The current Array#push reduction supports some amount of non-redundant
    homogeneous from its receiver maps, and unifies polymorphism by
    generating a push implementation per unique receiver elements kind,
    rather than per receiver map. It does this by dynamically reading off
    the receiver's elements kind, and branching on it.
    
    Reading off the receiver's elements kind dynamically is a bit of a waste
    though, since we already know the small subset of maps that are possible
    at this point, and have probably emitted diamonds for checking those
    maps which can't be merged with the dynamic elements kind lookup.
    
    In this patch, this code is changed in two major ways:
    
      1. We perform comparisons on the receiver map, rather than the
         receiver elements kind, and dispatch to the per-elements kind
         implementation after that check.
    
      2. We allow the Smi path to fallthrough into the Object elements path,
         once its Smi checks complete, to avoid generating distinct but
         identical grow-and-set code for both PACKED_ELEMENTS and
         PACKED_SMI_ELEMENTS.
    
    Change-Id: Ie7764339a0220cb30aee0592553e0dc98539ac79
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3912765Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83438}
    7bf63faf
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...