• Benedikt Meurer's avatar
    [stack-traces] Cache source position on StackFrameInfos. · 7b07c779
    Benedikt Meurer authored
    Previously we had cached the source position information on
    JSStackFrame (C++) objects and reused that between calls to
    GetLineNumber() and GetColumnNumber(). The refactoring in
    https://crrev.com/eed0d27c2f774b3adbc85d0a5fb30a8cf0f018a8
    effectively removed that cache, while still making things
    faster though.
    
    This CL puts back the caching on the StackFrameInfo objects
    by reusing the `offset` slot to store the computed source
    position (as indicated by a bit in the `flags`). For promise
    combinator async frames, the bit is always set and the
    `offset_or_source_position` slot thus always contains the source
    position (aka the `promise index` in this case). We also
    added a `StackFrameInfo::ComputeLocation()` method to remove the
    last remaining place where we'd peek into the StackFrameInfo from
    outside stack-frame-info.{cc,h}.
    
    Also-By: kimanh@chromium.org
    Bug: chromium:1077657, v8:8742, chromium:1069425
    Change-Id: I59e26a91965617163776e6cc2610b88e6925452c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2695386
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72752}
    7b07c779
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...