• Clemens Backes's avatar
    [liftoff] Fix >=2GB memory accesses on 32-bit · 7ad5b961
    Clemens Backes authored
    We were inconsistent in handling offsets >= 2GB on 32-bit systems. The
    code was still relying on this being detected as statically out of
    bounds, but with the increase of {kV8MaxWasmMemoryPages} to support 4GB
    memories, this is not the case any more.
    
    This CL fixes this by again detecting such situations as statically OOB.
    We do not expect to be able to allocate memories of size >2GB on such
    systems. If this assumptions turns out to be wrong, we will erroneously
    trap. If that happens, we will have to explicitly disallow memories of
    such size on 32-bit systems.
    
    R=jkummerow@chromium.org
    
    Bug: v8:7881, chromium:1201340
    Change-Id: Ic89a67d38fb860eb8a48a4ff51bc02c53f8a2c2a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848467Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74175}
    7ad5b961
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...