• littledan's avatar
    Throw the right exceptions from setting elements in Array.prototype.concat · 7acee1ef
    littledan authored
    This patch fixes two bugs in Array.prototype.concat in conjunction with
    subclassing Arrays:
    - Create a new property rather than calling Set when adding elements to
      the output array. This means setters are not called.
    - If there is an exception thrown from DefineProperty, propagate it
      outwards properly, rather than swallowing it. This can occur, e.g., with
      a Proxy as the new output array.
    
    R=adamk
    LOG=Y
    BUG=chromium:595319
    
    Review URL: https://codereview.chromium.org/1814933002
    
    Cr-Commit-Position: refs/heads/master@{#34876}
    7acee1ef
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...