• Adam Klein's avatar
    Revert "[turbofan] Masking/poisoning in codegen (optimized code, arm64)" · 797d3df0
    Adam Klein authored
    This reverts commit 800daded.
    
    Reason for revert: breaks arm64 build
    
    Original change's description:
    > [turbofan] Masking/poisoning in codegen (optimized code, arm64)
    > 
    > This introduces masking of loads with speculation bit during code generation.
    > At the moment, this is done only under the
    > --branch-load-poisoning flag, and this CL enlarges the set of supported
    > platforms from {x64, arm} to {x64, arm, arm64}.
    > 
    > Overview of changes:
    > - new register configuration configuration with one register reserved for
    >   the speculation poison/mask (kSpeculationPoisonRegister).
    > - in codegen, we introduce an update to the poison register at the starts
    >   of all successors of branches (and deopts) that are marked as safety
    >   branches (deopts).
    > - in memory optimizer, we lower all field and element loads to PoisonedLoads.
    > - poisoned loads are then masked in codegen with the poison register.
    >   * only integer loads are masked at the moment.
    > 
    > Bug: chromium:798964
    > Change-Id: Ie6bc9c3bdac9998b0ef81f050a9c844399ca3ae4
    > Reviewed-on: https://chromium-review.googlesource.com/928724
    > Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    > Reviewed-by: Martyn Capewell <martyn.capewell@arm.com>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#51576}
    
    TBR=rmcilroy@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org,jarin@chromium.org,rodolph.perfetta@arm.com,martyn.capewell@arm.com,pierre.langlois@arm.com
    
    Change-Id: I1b5dad27f9620c7da3277602081f392de6221caf
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:798964
    Reviewed-on: https://chromium-review.googlesource.com/937861Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51578}
    797d3df0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...