• Clemens Backes's avatar
    [asm] Fix use-after-free in ZoneVectors · 7887ae6f
    Clemens Backes authored
    The AsmParser kept pointers into ZoneVectors, which were accessed even
    after those vector might have grown. For regular vectors, this would be
    a use-after-free; with ZoneVectors it is technically allowed, since the
    old memory stays alive. This will change with
    https://crrev.com/c/2302895, which zaps zone memory which is
    deallocated. Eventually, we might want to reuse large deallocations in
    zone memory, hence this "use after free" needs to be fixed.
    
    This CL fixes the issue by explicitly re-allocating in the zone instead
    of using ZoneVectors. This makes sure that the old memory stays alive.
    This is kind of a quick-fix, but since asm.js is more or less deprecated
    anyway (in favor of Wasm), it's OK if this code does not profit from
    future ZoneVector memory re-use optimizations.
    
    Drive-by: Move field initializers to the field declaration.
    
    R=ishell@chromium.org
    
    Bug: v8:10717
    Change-Id: I56c1feb49d05080e78a6620273b55b4e18156254
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304581Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68917}
    7887ae6f
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...