• Benedikt Meurer's avatar
    [inspector] Set limit for Wasm wire byte transfer via CDP. · 7842920a
    Benedikt Meurer authored
    The `Debugger.getScriptSource()` and `Debugger.getWasmBytecode()`
    methods in the CDP return Wasm wire bytes as protocol::Binary, which is
    send as Base64-encoded JSON string in the communication to the DevTools
    front-end, and hence leads to either crashing the renderer that is being
    debugged or the renderer that's running the front-end if we allow
    arbitrarily huge Wasm byte sequences here. This CL introduces a limit,
    based on the maximum allowed string length, to avoid the crash and
    instead signal a proper error to the DevTools front-end.
    
    Bug: chromium:1099680
    Change-Id: I356d617301d17a4012f7f845773cf14e6ad1e4a7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270174
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68560}
    7842920a
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...