• Bill Budge's avatar
    Revert "Revert "[debugger] do not try to find saved context before DebugEvaluate::Local"" · 781fa726
    Bill Budge authored
    This reverts commit 2a8e1e4a.
    
    Reason for revert: Time outs were caused by infra issues.
    
    Original change's description:
    > Revert "[debugger] do not try to find saved context before DebugEvaluate::Local"
    > 
    > This reverts commit ea7499df.
    > 
    > Reason for revert: Speculative, but this CL seems correlated with a bunch of timeouts on Linux:
    > 
    > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/19540
    > 
    > Original change's description:
    > > [debugger] do not try to find saved context before DebugEvaluate::Local
    > > 
    > > Current implementation produces crashes since sometimes saved context
    > > is empty. It looks like we do not need to restore saved context since
    > > we do not set debug context as current, at least all tests are passed.
    > > 
    > > R=​yangguo@chromium.org
    > > 
    > > Bug: chromium:797573,chromium:792838
    > > Change-Id: I1271640f6a18cbaaecfa1e99ed9ac28e0dbbb1da
    > > Reviewed-on: https://chromium-review.googlesource.com/844979
    > > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#50327}
    > 
    > TBR=yangguo@chromium.org,kozyatinskiy@chromium.org
    > 
    > Change-Id: I543201698c96c9762c481c1f6012cc13cb712842
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: chromium:797573, chromium:792838
    > Reviewed-on: https://chromium-review.googlesource.com/846205
    > Reviewed-by: Bill Budge <bbudge@chromium.org>
    > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#50331}
    
    TBR=bbudge@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org
    
    Change-Id: I44e916c796b935c372ce418a3fad44aa25d6f863
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:797573, chromium:792838
    Reviewed-on: https://chromium-review.googlesource.com/848132Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50332}
    781fa726
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...