• vogelheim's avatar
    Always dispose backing store. · 7770e021
    vogelheim authored
    (With a v8::Vector, the client is responsible for memory management.
     I think there can be a situation where the Vector has a char[1] backing
     store with '\0' in it, in which case the current code would leak.
     If we always Dispose() the backing store this should be avoided.
     Since dispose will delete[] the actual backing store, this should
     also work then the backing store is nullptr.)
    
    R=jochen@chromium.org
    BUG=chromium:525885
    LOG=N
    
    Review URL: https://codereview.chromium.org/1410543005
    
    Cr-Commit-Position: refs/heads/master@{#31446}
    7770e021
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...