• bmeurer's avatar
    [turbofan] Improve graph for JumpIfTrue/False and JumpIfToBooleanTrue/False. · 776a5c10
    bmeurer authored
    Avoid the useless strict equality comparisons with true/false being
    generated for the JumpIfTrue, JumpIfFalse, JumpIfToBooleanTrue and
    JumpIfToBooleanFalse bytecodes. Instead feed the accumulator (or the
    outcome of ToBoolean) directly to the Branch node and do the negation
    as part of the control flow.
    
    The previous subraphs would render the loop variable analysis useless,
    and would cause a lot of unnecessary bit materialization, because many
    of our optimizations don't kick in.
    
    Note: This is only part of the problem, there are more subtle differences
    in the bytecode pipeline that prevent several important optimizations to
    kick in.
    
    R=mstarzinger@chromium.org
    BUG=v8:5267,v8:5348
    
    Review-Url: https://codereview.chromium.org/2309733002
    Cr-Commit-Position: refs/heads/master@{#39151}
    776a5c10
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...