• Peter Marshall's avatar
    [tracing] Use ChromeTracePacket to save binary size with perfetto · 76f85199
    Peter Marshall authored
    Previously, compiling with perfetto would add 2.3 MiB to the d8 release
    binary. With this change it's 472 KiB.
    
    This is because trace:lite pulls in many more compiled proto classes
    than we need, e.g. a bunch of stuff under ftrace/ which is only used
    on Android.
    
    Chrome uses a 'mirror proto' ChromeTrackPacket to only provide
    compiled protos for the types of packets it will actually see, which on
    non-android devices does not include anything under ftrace/.
    
    We use the same trick here in the JSON consumer.
    
    Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng
    Bug: v8:8339
    Change-Id: Iae1f74eec3bd93b18e9f069701fc016440d3ce5e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619759
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Auto-Submit: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61662}
    76f85199
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...