• Seth Brenith's avatar
    [torque] Use @generateCppClass in some simple cases · 14274bb1
    Seth Brenith authored
    This change is mostly mechanical, but it's worth mentioning a few
    slightly interesting cases:
    - A couple of field definitions didn't match the signedness of their
      corresponding accessors.
    - The generated accessors for Smi data use Smi values directly, but
      usually we want C++ accessors to use ints instead. I added a macro
      that hides the generated Smi accessors and exposes int accessors,
      but we might consider generating int accessors directly.
    - The data held in some fields is described in comments next to the
      accessor definition for those fields. With automatically generated
      accessors, those comments need a new home. In this change I put them
      in the Torque object definition, but I'm open to other suggestions.
    - gen-postmortem-metadata couldn't find updated class definitions after
      they got split across multiple lines, so I changed its matching
      logic. (Ideally debug-support.cc should be a Torque compiler output
      rather than something that involves parsing C++ with regexes, but
      this makes it correctly report subclass relationships for now.)
    - The end offsets generated by Torque were off by one from the values
      that would be generated by DEFINE_FIELD_OFFSET_CONSTANTS.
    
    Change-Id: I3df4fcd27997b46c41ca879065b9d97f6c939f07
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692192Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#62719}
    14274bb1
Name
Last commit
Last update
..
ls Loading commit data...
OWNERS Loading commit data...
ast.h Loading commit data...
cfg.cc Loading commit data...
cfg.h Loading commit data...
constants.h Loading commit data...
contextual.h Loading commit data...
csa-generator.cc Loading commit data...
csa-generator.h Loading commit data...
declarable.cc Loading commit data...
declarable.h Loading commit data...
declaration-visitor.cc Loading commit data...
declaration-visitor.h Loading commit data...
declarations.cc Loading commit data...
declarations.h Loading commit data...
earley-parser.cc Loading commit data...
earley-parser.h Loading commit data...
global-context.cc Loading commit data...
global-context.h Loading commit data...
implementation-visitor.cc Loading commit data...
implementation-visitor.h Loading commit data...
instructions.cc Loading commit data...
instructions.h Loading commit data...
parameter-difference.h Loading commit data...
server-data.cc Loading commit data...
server-data.h Loading commit data...
source-positions.cc Loading commit data...
source-positions.h Loading commit data...
torque-compiler.cc Loading commit data...
torque-compiler.h Loading commit data...
torque-parser.cc Loading commit data...
torque-parser.h Loading commit data...
torque.cc Loading commit data...
type-oracle.cc Loading commit data...
type-oracle.h Loading commit data...
type-visitor.cc Loading commit data...
type-visitor.h Loading commit data...
types.cc Loading commit data...
types.h Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...