• Stephan Herhut's avatar
    Revert "[regalloc] More aggressively reuse spill ranges for phi inputs" · 767b152a
    Stephan Herhut authored
    Turns out TryReuseSpillForPhi does more than reusing a spill slot for a
    phi (which is beneficial in general). It also decides whether a phi
    should start out to be allocated in a spill slot. The latter, of course,
    benefits from control flow knowledge. Hence, this change was detrimental
    in cases where a common input to a phi is only spilled on few control
    flow pathes.
    
    To fix, we need to disentangle spill-slot reuse and the decision whether
    a phi should start out spilled. I will look into this in a follow up
    change.
    
    This reverts commit b79cbd56.
    
    Change-Id: I228185bb1a4b320d3115ba7f1d921593480d8e7d
    Reviewed-on: https://chromium-review.googlesource.com/c/1304549Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Stephan Herhut <herhut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57113}
    767b152a
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...