• adamk's avatar
    Don't treat catch scopes as possibly-shadowing for sloppy eval · 75f2d65f
    adamk authored
    Scope analysis is over-conservative when treating variable resolutions
    as possibly-shadowed by a sloppy eval. In the attached bug, this comes
    into play since catch scopes have different behavior with respect to
    the "calls eval" in eager vs lazy compilation (in the latter, they
    are never marked as "calls eval" because CatchContexts don't have
    an associated ScopeInfo).
    
    This patch changes the scope-type check to also eliminate a few other
    cases where shadowing isn't possible, such as non-declaration block scopes.
    
    BUG=chromium:608279
    LOG=n
    
    Review-Url: https://codereview.chromium.org/1950803002
    Cr-Commit-Position: refs/heads/master@{#36046}
    75f2d65f
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...