• Clemens Backes's avatar
    [wasm] Extend debug side table for registers · 75931f18
    Clemens Backes authored
    This extends the debug side table to also store register locations in
    addition to constants and stack values.
    Previously, every value that was not constant was assumed to be spilled
    to the stack. This made sense, because without breakpoints we would only
    emit debug side table entries at call sites, where all registers are
    spilled.
    With breakpoints, this changes. At break locations, values might be live
    in registers.
    
    The logic to decide whether a value will live in the register or on the
    stack is extended, because we sometimes generate the debug side table
    entry at a point where the registers are not spilled yet. The debug side
    table entry creation needs to account for that, and assume that these
    registers will still be spilled.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10147, v8:10222
    Change-Id: I3b020dfaa29fc007047663706ee286180a996bfd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066960
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66407}
    75931f18
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...