• Clemens Hammacher's avatar
    Revert "[utils] Make BitField final" · 753a07db
    Clemens Hammacher authored
    This reverts commit 658ff200.
    
    Reason for revert: Fails no-i18n bot: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20noi18n%20-%20debug/27826
    
    Original change's description:
    > [utils] Make BitField final
    > 
    > We have hundreds of classes that derive from {BitField} without adding
    > any functionality. This CL switches all such occurrences to 'using'
    > declarations instead.
    > 
    > Before:
    >   class MyBitField : public BitField<int, 6, 4, MyEnum> {};
    > After:
    >   using MyBitField = BitField<int, 6, 4, MyEnum>;
    > 
    > This might reduce compilation time by reducing the number of existing
    > classes.
    > 
    > The old pattern is forbidden now by making {BitField} final.
    > 
    > R=​yangguo@chromium.org
    > 
    > Bug: v8:9396, v8:7629
    > Change-Id: I8a8364707e8eae0bb522af2459c160e3293eecbb
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1722565
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#62956}
    
    TBR=yangguo@chromium.org,clemensh@chromium.org
    
    Change-Id: I50234a09c77aa89fdcf1e01c2497cc08d3ac79a8
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9396, v8:7629
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1724377Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62958}
    753a07db
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...