• Peter Marshall's avatar
    [inspector] Add a test for const declaration and side effects · 73f4ac62
    Peter Marshall authored
    Add a test that does the same thing the devtools-frontend does when
    evaluating console inputs.
    
    1) Declare a const variable with throwOnSideEffect=true. This should
    throw.
    2) Declare the same const variable with throwOnSideEffect=false.
    This should successfully declare the variable.
    
    Previously it could be the case that even though we threw in 1), the
    variable would fail to be initialized in 2) with a re-declaration
    error.
    
    Bug: chromium:1043151
    Change-Id: I1a6126b518f7bb3788c39b9f8e3adb8850aa962a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2016587
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65991}
    73f4ac62
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...