• Benedikt Meurer's avatar
    [inspector] Consistently format value wrappers in console messages. · 3b150938
    Benedikt Meurer authored
    When formatting console messages (for consumption in Chromium/Blink), we
    have special logic to unwrap value wrapper objects. But this logic was
    not very consistent, and especially Number values and NumberObject
    values were formatted differently.
    
    This changes the V8ValueStringBuilder::append() logic to always unwrap
    any value wrapper first and then use the regular dispatch for the
    primitive value.
    
    Fixed: chromium:1321833
    Change-Id: I9996671e1f91da0841e5d5f1687cf647ab72a561
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622913
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80323}
    3b150938
Name
Last commit
Last update
..
console Loading commit data...
cpu-profiler Loading commit data...
debugger Loading commit data...
heap-profiler Loading commit data...
regress Loading commit data...
runtime Loading commit data...
sessions Loading commit data...
type-profiler Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
frontend-channel.h Loading commit data...
inspector-test.cc Loading commit data...
inspector.status Loading commit data...
isolate-data.cc Loading commit data...
isolate-data.h Loading commit data...
json-parse-expected.txt Loading commit data...
json-parse.js Loading commit data...
print-method-not-found-expected.txt Loading commit data...
print-method-not-found.js Loading commit data...
protocol-test.js Loading commit data...
task-runner.cc Loading commit data...
task-runner.h Loading commit data...
tasks.cc Loading commit data...
tasks.h Loading commit data...
testcfg.py Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...
wasm-inspector-test.js Loading commit data...