• mlippautz's avatar
    Revert of [heap] Ensure progress when incrementally marking wrappers (patchset... · 73036fb6
    mlippautz authored
    Revert of [heap] Ensure progress when incrementally marking wrappers (patchset #3 id:60001 of https://codereview.chromium.org/2592403002/ )
    
    Reason for revert:
    This won't work because the finalization still checks whether both marking deques are empty, also calling into blink. So we never proceed there.
    
    Original issue's description:
    > [heap] Ensure progress when incrementally marking wrappers
    >
    > The problem here is estimating the marking step size for wrapper tracing. If the
    > steps are too small, we cannot keep up with the mutator creating new wrappers.
    > The result is an endless stream of incremental marking steps, alternating v8 and
    > wrappers tracing, without ever finalizing in a GC.
    >
    > The mitigation here is to abort finding the fix point after 10 incremental
    > iterations.
    >
    > A proper solution would track newly created wrappers on the blink side during
    > wrapper tracing. Will give this more thought after the holidays.
    >
    > BUG=chromium:668164, chromium:468240
    >
    > Review-Url: https://codereview.chromium.org/2592403002
    > Cr-Commit-Position: refs/heads/master@{#41923}
    > Committed: https://chromium.googlesource.com/v8/v8/+/a47417b89373c615f9256800cfc803d84ba58378
    
    TBR=ulan@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=chromium:668164, chromium:468240
    
    Review-Url: https://codereview.chromium.org/2602433002
    Cr-Commit-Position: refs/heads/master@{#41924}
    73036fb6
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...