• Seth Brenith's avatar
    [torque] Strict verification of weak fields · 72d440d9
    Seth Brenith authored
    Now that we can represent specific weak types with Weak<T>, this CL
    updates the generated verifier functions so that they permit weak
    references only to the specified type. As an example, consider the
    verifier emitted for the following field in PrototypeInfo:
    
      object_create_map: Weak<Map>|Undefined;
    
    We used to emit the following, which allowed any weak reference:
    
      CHECK(object_create_map__value.IsWeakOrCleared()
          || object_create_map__value.GetHeapObjectOrSmi().IsOddball());
    
    With this change, we emit a stricter check:
    
      CHECK(object_create_map__value.IsCleared()
          || (!object_create_map__value.IsWeak()
              && object_create_map__value.GetHeapObjectOrSmi().IsOddball())
          || (object_create_map__value.IsWeak()
              && object_create_map__value.GetHeapObjectOrSmi().IsMap()));
    
    Bug: v8:7793
    Change-Id: I4be236d97dedbcdd6c98207928aee8bda2a77f00
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914613
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64965}
    72d440d9
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...