• Mike Stanton's avatar
    [compiler] Address two concurrency TODOs · 72c8f3fb
    Mike Stanton authored
    JSHeapBroker::ReadFeedbackForCall() - it may be that the JSFunction
    we read in the feedback vector hasn't been store-ordered and is
    therefore unsafe to read. Therefore, we need to call the gc
    predicate to ensure safety.
    
    JSFunctionRef::feedback_vector() & raw_feedback_cell() - I was able
    to remove the TODO warning about uninitialized data visible from
    a direct read of these fields from the background. This is because
    we either store-order into those fields, or rely on a prior
    store-ordering. Additionally, FeedbackVectorRef and FeedbackCellRef
    are never-serialized objects, so their first encounter on the
    background thread is fine (we don't need to have seen and
    serialized them on the main thread first).
    
    Bug: v8:7790
    Change-Id: I9cd19999e70fadcf62778dac2b0f679966a4a53f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3026708Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75720}
    72c8f3fb
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...