• Daniel Bevenius's avatar
    [heap] Add large_object_threshold to AllocateRaw · 71736859
    Daniel Bevenius authored
    This commit adds a check in Heap::AllocateRaw when setting the
    large_object variable, when the AllocationType is of type kCode, to
    take into account the size of the CodeSpace's area size.
    
    The motivation for this change is that without this check it is
    possible that size_in_bytes is less than 128, and hence not considered
    a large object, but it might be larger than the available space
    in code_space->AreaSize(), which will cause the object to be created
    in the CodeLargeObjectSpace. This will later cause a segmentation fault
    when calling the following chain of functions:
    
       if (!large_object) {
          MemoryChunk::FromHeapObject(heap_object)
              ->GetCodeObjectRegistry()
              ->RegisterNewlyAllocatedCodeObject(heap_object.address());
       }
    
    We (Red Hat) ran into this issue when running Node.js v12.16.1 in
    combination with yarn on aarch64 (this was the only architecture that
    this happed on).
    
    Bug: v8:10808
    
    Change-Id: I0c396b0eb64bc4cc91d9a3be521254f3130eac7b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2390665
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69876}
    71736859
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...