• Ali Ijaz Sheikh's avatar
    [heap] do not perform a step while a space is partially mutated · 70c02375
    Ali Ijaz Sheikh authored
    We were starting an allocation step during NewSpace::AddFreshPage. At
    this point, we had advanced the page, but not updated allocation_info_.
    This ultimately led to assertions as Space::Size was not expecting
    to be called when to_space_.page_{high,low} are inconsistent with
    allocation_info_.top().
    
    The solution here is to avoid starting the step in the middle of the
    space state mutation. We account for memory allocated so far before the
    mutation is started, and then start a new step after the mutation has
    been completed.
    
    Bug: chromium:806179
    Change-Id: I17ee896d80c4ec752baa2b17c3fd2bef7ea2ca33
    Reviewed-on: https://chromium-review.googlesource.com/889981Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com>
    Cr-Commit-Position: refs/heads/master@{#50932}
    70c02375
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...