• Leszek Swirski's avatar
    [test] Robustify wait in regress-bug-9161 · 70a0baaa
    Leszek Swirski authored
    mjsunit/regress/regress-crbug-9161 had two spinlocks on an atomic:
    
      1. WaitUntil(lock == kStageRunning)
      2. WaitUntil(lock == kStageDone)
    
    But, in theory the worker updating the "lock" could progress all the way
    to kStageDone before the first loop manages to check the lock value
    again.
    
    We can make this more robust by checking:
    
      1. WaitUntil(lock != kStageInit)
      2. WaitUntil(lock == kStageDone)
    
    That way both loops check for _any_ state past the state they want to
    progress past.
    
    Bug: v8:11437
    Change-Id: I5220e61070a305301c678928edb0925c04dae970
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231339
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77460}
    70a0baaa
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...