• cbruni's avatar
    Copy dictionary keys and values in enumeration in TransferNamedProperties · 7036eec6
    cbruni authored
    During bootstrapping when installing the global object we copy over the
    properties from the snapshotted global object to the one created from a
    provided template. Originally Genesis::TransferNamedProperties just iterated
    over the entries, making the final order hash and thus platform dependent.
    This CL fixes this by sorting the keys by enumeration index before copying them
    to the destination object and thus making the key enumaration on the global
    object platform independent.
    
    Drive-by-fix: avoid crash when printing the global object during bootstrapping.
    
    BUG=chromium:669029
    
    Review-Url: https://codereview.chromium.org/2533223002
    Cr-Commit-Position: refs/heads/master@{#41502}
    7036eec6
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...