• littledan's avatar
    Optimize @@species based on a global 'protector' cell · 7033ae51
    littledan authored
    This patch makes ArraySpeciesCreate fast in V8 by avoiding two property reads
    when the following conditions are met:
    - No Array instance has had its __proto__ reset
    - No Array instance has had a constructor property defined
    - Array.prototype has not had its constructor changed
    - Array[Symbol.species] has not been reset
    
    For subclasses of Array, or for conditions where one of these assumptions is
    violated, the full lookup of species is done according to the ArraySpeciesCreate
    algorithm. Although this is a "performance cliff", it does not come up in the
    expected typical use case of @@species (Array subclassing), so it is hoped that
    this can form a good start. Array subclasses will incur the slowness of looking
    up @@species, but their use won't slow down invocations of, for example,
    Array.prototype.slice on Array base class instances.
    
    Possible future optimizations:
    - For the fallback case where the assumptions don't hold, optimize the two
      property lookups.
    - For Array.prototype.slice and Array.prototype.splice, even if the full lookup
      of @@species needs to take place, we still could take the rest of the C++
      fastpath. However, to do this correctly requires changing the calling convention
      from C++ to JS to pass the @@species out, so it is not attempted in this patch.
    
    With this patch, microbenchmarks of Array.prototype.slice do not suffer a
    noticeable performance regression, unlike their previous 2.5x penalty.
    
    TBR=hpayer@chromium.org
    
    Review URL: https://codereview.chromium.org/1689733002
    
    Cr-Commit-Position: refs/heads/master@{#34199}
    7033ae51
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
fuzzer Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
simdjs Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
webkit Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
ignition.gyp Loading commit data...
ignition.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...