• Clemens Backes's avatar
    [wasm][debug] Fix location computation from interpreted frames · 700f9b0e
    Clemens Backes authored
    The {IsWasmFrame} check in {ComputeLocationFromStackTrace} only returned
    true for compiled frames, but not for interpreted ones. Thus, for
    interpreted frames we would run into the code for JS frames, which
    assumes that a {JSFunction} is available.
    
    This CL fixes this issue by renaming {IsWasmFrame} to
    {IsWasmCompiledFrame}, and introducing a new {IsWasmFrame} method which
    returns true for both compiled and interpreted frames.
    
    R=mstarzinger@chromium.org
    
    Bug: chromium:1018227
    Change-Id: If83b4129edaad775a212ccb741f3c62eabc2addb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1883892Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64607}
    700f9b0e
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...