• Leszek Swirski's avatar
    Reland "[offthread] Template deserializer on Isolate" · 6f898234
    Leszek Swirski authored
    This is a reland of e24fa913
    It fixes the heap verification errors by going back to using MakeThin
    instead of manually creating a filler (that then makes the verifier
    think that this was array left-trimming).
    
    Original change's description:
    > [offthread] Template deserializer on Isolate
    >
    > Make the deserializer class templated on Isolate/LocalIsolate. This
    > allows the ObjectSerializer to be split into a main-thread and offthread
    > variant, with the latter taking a LocalIsolate.
    >
    > Eventually, we probably want to anyway split off the code-cache de/serializer
    > to a separate implementation (for various reasons), and this the only one that
    > wants off-thread finalization, and at this point the deserializer can revert
    > back to being un-templated, used only for bootstrapping. However, this is the
    > simplest way, for now, to enable off-thread deserialization.
    >
    > Bug: chromium:1075999
    > Change-Id: I49c0d2c5409f0aa58183673785296756c3714f22
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562254
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75834}
    
    Bug: chromium:1075999
    Change-Id: I1d81fad2550a2a9f04dd0f9d8e66422d28faf378
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3043960Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75918}
    6f898234
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...