• Benedikt Meurer's avatar
    [async] Add Promise.all() support to --async-stack-traces. · 6f39ab89
    Benedikt Meurer authored
    This adds support for Promise.all() to --async-stack-traces (also at
    zero cost, since we can derive the relevant information from the resolve
    element closure and context). In case of `Promise.all(a)` the stack
    trace even tells you which element of `a` is responsible, for example
    
    ```js
    async function fine() {}
    async function thrower() { await fine(); throw new Error(); }
    async function test() { await Promise.all([fine(), thrower()]); }
    ```
    
    will generate the following stack trace
    
    ```
    Error
        at thrower (something.js:1:9)
        at async Promise.all (index 1)
        at async test (something.js:3:3)
    ```
    
    so it not only shows the async Promise.all() frames, but even tells the
    user exactly that the second element of `[fine(), thrower()]` is the
    relevant one.
    
    Bug: v8:7522
    Change-Id: I279a845888e06053cf0e3c9338ab71caabaabf45
    Reviewed-on: https://chromium-review.googlesource.com/c/1299248Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57023}
    6f39ab89
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...