• Daniel Bevenius's avatar
    [torque] Use char newline character instead of string · 32b22fe9
    Daniel Bevenius authored
    Currently, when GeneratePrintDefinitionsForClass generates its Print
    functions it uses a string literal as the newline character for all the
    last lines. For example:
    
    void TorqueGeneratedStruct<Struct, HeapObject>::StructPrint(
        std::ostream& os) {
      this->PrintHeader(os, "TorqueGeneratedStruct");
      os << "\n";
    }
    
    The last line could use a single character instead of a string,
    for example:
    
    void TorqueGeneratedStruct<Struct, HeapObject>::StructPrint(
        std::ostream& os) {
      this->PrintHeader(os, "TorqueGeneratedStruct");
      os << '\n';
    }
    
    The commit suggests changing this into a char.
    
    Change-Id: Id7a2f5fb17108fcbb543109d18b6b474ac1c5d2d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2108546Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66788}
    32b22fe9
Name
Last commit
Last update
..
ls Loading commit data...
OWNERS Loading commit data...
ast.h Loading commit data...
cfg.cc Loading commit data...
cfg.h Loading commit data...
class-debug-reader-generator.cc Loading commit data...
constants.h Loading commit data...
contextual.h Loading commit data...
csa-generator.cc Loading commit data...
csa-generator.h Loading commit data...
declarable.cc Loading commit data...
declarable.h Loading commit data...
declaration-visitor.cc Loading commit data...
declaration-visitor.h Loading commit data...
declarations.cc Loading commit data...
declarations.h Loading commit data...
earley-parser.cc Loading commit data...
earley-parser.h Loading commit data...
global-context.cc Loading commit data...
global-context.h Loading commit data...
implementation-visitor.cc Loading commit data...
implementation-visitor.h Loading commit data...
instance-type-generator.cc Loading commit data...
instructions.cc Loading commit data...
instructions.h Loading commit data...
parameter-difference.h Loading commit data...
runtime-support.h Loading commit data...
server-data.cc Loading commit data...
server-data.h Loading commit data...
source-positions.cc Loading commit data...
source-positions.h Loading commit data...
torque-compiler.cc Loading commit data...
torque-compiler.h Loading commit data...
torque-parser.cc Loading commit data...
torque-parser.h Loading commit data...
torque.cc Loading commit data...
type-inference.cc Loading commit data...
type-inference.h Loading commit data...
type-oracle.cc Loading commit data...
type-oracle.h Loading commit data...
type-visitor.cc Loading commit data...
type-visitor.h Loading commit data...
types.cc Loading commit data...
types.h Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...