• Seth Brenith's avatar
    Fix crashes introduced by "Fix leaks due to deoptimization literals" · 6e9f5de2
    Seth Brenith authored
    My previous change https://crrev.com/c/3160299 introduced a runtime
    CHECK that crashes the process if V8 attempts to read a deoptimization
    literal which has been cleared. That CHECK is indeed crashing the
    process.
    
    It appears that the trouble arises in cases where the deoptimization
    data indicates that an object should be materialized as needed. In those
    cases, one of the deoptimization literals is the Map to use when
    materializing the object. It is possible to reach a part of the code
    that requires the materialized object, and therefore the Map, without
    there being any other owner of that Map. This is in contrast to most
    other deoptimization literals, which are logically equivalent to omitted
    values from the stack frame and therefore can't be reached without a
    real owner somewhere to keep them alive.
    
    To fix, I propose referring to Maps strongly from the deoptimization
    literals. The cases I investigated in v8:4578 didn't involve Maps, so I
    believe that the observed memory leaks are still fixed with this change.
    
    Bug: chromium:1268681, chromium:1268683, chromium:1268825, v8:12300
    Change-Id: Ifd32a7f9cc29e0384650013ab16e05646bf57895
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3272880
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77857}
    6e9f5de2
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...