• Patrick Thier's avatar
    Improve error messages for property access on null/undefined · 24c626c1
    Patrick Thier authored
    Only print the property name when accessing null/undefined if we can
    convert it to a string without causing side effects.
    If we can't, omit the property name in the error message.
    This should avoid confusion when the key is an object with toString().
    E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object
    Object]' anymore, which was misleading since the property accessed would
    be 'a', but we can't evaluate the key without side effects.
    
    Bug: v8:11365
    Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75250}
    24c626c1
Name
Last commit
Last update
..
bugs/harmony Loading commit data...
debug Loading commit data...
protocol Loading commit data...
regress Loading commit data...
wrapper Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...
debugger.status Loading commit data...
test-api.js Loading commit data...
testcfg.py Loading commit data...