• Patrick Thier's avatar
    [regexp] Secure interpreter dispatch. · 67a70d7e
    Patrick Thier authored
    Currently the dispatch table could be accessed out of bounds if something
    is wrong with the generated bytecode.
    OOB access of the dispatch table can lead to jumps to arbitrary addresses
    in the code space.
    
    This CL prevents this issue by changing the following:
    BYTECODE_MASK now filters out all bits not currently used for bytecodes.
    All unused slots between the last actually defined bytecode and
    BYTECODE_MASK are now filled with BREAK Bytecodes (invalid operation).
    This way we can not access out of bounds of the dispatch table if
    something is broken/tampered with, preventing jumps to arbitrary code.
    
    Bug: v8:9699
    Change-Id: Ibce591ae94b52472ba74a9fd0666e55185af7b2c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795349
    Commit-Queue: Patrick Thier <pthier@google.com>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63708}
    67a70d7e
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
gen-regexp-special-case.cc Loading commit data...
property-sequences.cc Loading commit data...
property-sequences.h Loading commit data...
regexp-ast.cc Loading commit data...
regexp-ast.h Loading commit data...
regexp-bytecode-generator-inl.h Loading commit data...
regexp-bytecode-generator.cc Loading commit data...
regexp-bytecode-generator.h Loading commit data...
regexp-bytecodes.h Loading commit data...
regexp-compiler-tonode.cc Loading commit data...
regexp-compiler.cc Loading commit data...
regexp-compiler.h Loading commit data...
regexp-dotprinter.cc Loading commit data...
regexp-dotprinter.h Loading commit data...
regexp-interpreter.cc Loading commit data...
regexp-interpreter.h Loading commit data...
regexp-macro-assembler-arch.h Loading commit data...
regexp-macro-assembler-tracer.cc Loading commit data...
regexp-macro-assembler-tracer.h Loading commit data...
regexp-macro-assembler.cc Loading commit data...
regexp-macro-assembler.h Loading commit data...
regexp-nodes.h Loading commit data...
regexp-parser.cc Loading commit data...
regexp-parser.h Loading commit data...
regexp-stack.cc Loading commit data...
regexp-stack.h Loading commit data...
regexp-utils.cc Loading commit data...
regexp-utils.h Loading commit data...
regexp.cc Loading commit data...
regexp.h Loading commit data...
special-case.h Loading commit data...