• Georgia Kouveli's avatar
    [instruction-scheduler] Add a RandomNumberGenerator to InstructionScheduler · 6be9ac9d
    Georgia Kouveli authored
    When running the tests with --turbo-stress-instruction-scheduling, there are
    crashes in the cases where there is no isolate, since we used the random
    generator from the isolate. This change introduces a RandomNumberGenerator to
    the instruction scheduler instead.
    
    We use the value from --random-seed for seeding the random number generator.
    We don't treat a zero value specially, as the feature is meant to be used with
    the test system which always sets a random seed and doesn't rely on default
    behaviour. This also means that the instruction scheduler will always produce
    the same result for the same input within the same run, which fixes another
    issue with the x64 jump optimisation: when that optimisation is enabled, the
    backend is ran twice, and previously it was producing a different schedule
    each time, thus collecting incorrect jump information.
    
    Bug: v8:9884
    Change-Id: I00394a7e50d0c502254b18490ebaf28a38d8f819
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1895555Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com>
    Cr-Commit-Position: refs/heads/master@{#64769}
    6be9ac9d
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...