• Clemens Hammacher's avatar
    [wasm] Store WasmModule in shared_ptr during async compilation · 6be6ec00
    Clemens Hammacher authored
    We currently store the {WasmModule} (generated during decoding) in a
    unique_ptr and pass ownership to the {WasmModuleObject} after
    compilation.
    I plan to move the {Managed<NativeModule>} from {WasmCompiledModule} to
    {WasmModuleObject}, which will force us to create the
    {WasmModuleObject} *before* compilation, so that the {CompilationState}
    is available during compilation.
    
    This CL prepares that refactoring by storing the {WasmModule} in a
    {shared_ptr} in the {AsyncCompileJob}. Note that it will eventually be
    stored in a {shared_ptr} in the {Managed} anyway.
    
    R=titzer@chromium.org
    
    Change-Id: Iac5e3c1067af2801e938f77a455a68807801526a
    Reviewed-on: https://chromium-review.googlesource.com/1104117
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53801}
    6be6ec00
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...