• Iain Ireland's avatar
    [regexp] Handlify RegExpCompileData::code · 6bb3f0c0
    Iain Ireland authored
    RegExpMacroAssembler::GetCode returns a Handle<Object>. However, that
    Handle is almost immediately dereferenced, and is stored as a bare
    Object in both RegExpCompiler::CompilationResult and RegExpCompileData.
    
    This makes SpiderMonkey's rooting hazard analysis somewhat
    antsy. While RegExpCompileData is alive on the stack, the hazard
    analysis will not allow any calls that might GC, because it isn't
    smart enough to prove that the code field can't be clobbered by a GC.
    
    As far as I can tell, there is no real hazard here, but storing a
    Handle in RegExpCompileData instead of a bare Object will simplify SM
    and prevent a future patch from accidentally breaking something.
    
    Bug: v8:10406
    Change-Id: I9642dd05c591bfd23b340a89df2f2bf5c9fcac2c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2161578Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67441}
    6bb3f0c0
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...