• Clemens Backes's avatar
    [wasm] Disallow nullptr modules in decoder · 6b633af7
    Clemens Backes authored
    In production, we will always pass a pointer to the decoded module. The
    only reason for the existance of the nullptr checks is that tests
    sometimes don't pass a module here. Hence we pay in production code for
    a test-only feature.
    
    This CL fixes this by always passing a module pointer from the decoder
    tests. This even simplifies the code a lot by removing redundant code.
    
    The {TestModuleBuilder} class was moved before the definitions of the
    {FunctionBodyDecoderTest} class in order to be able to reuse it there.
    It's unmodified otherwise.
    
    R=ahaas@chromium.org
    
    Bug: v8:10576
    Change-Id: I7d876bfc8a27b50fe713afb8848fb4f642287cfa
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2226749Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68116}
    6b633af7
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...