• Nico Hartmann's avatar
    Revert "[arm64] Protect return addresses stored on stack" · 6a9a67d9
    Nico Hartmann authored
    This reverts commit 137bfe47.
    
    Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Arm%20-%20debug/13072
    
    Original change's description:
    > [arm64] Protect return addresses stored on stack
    > 
    > This change uses the Arm v8.3 pointer authentication instructions in
    > order to protect return addresses stored on the stack.  The generated
    > code signs the return address before storing on the stack and
    > authenticates it after loading it. This also changes the stack frame
    > iterator in order to authenticate stored return addresses and re-sign
    > them when needed, as well as the deoptimizer in order to sign saved
    > return addresses when creating new frames. This offers a level of
    > protection against ROP attacks.
    > 
    > This functionality is enabled with the v8_control_flow_integrity flag
    > that this CL introduces.
    > 
    > The code size effect of this change is small for Octane (up to 2% in
    > some cases but mostly much lower) and negligible for larger benchmarks,
    > however code size measurements are rather noisy. The performance impact
    > on current cores (where the instructions are NOPs) is single digit,
    > around 1-2% for ARES-6 and Octane, and tends to be smaller for big
    > cores than for little cores.
    > 
    > Bug: v8:10026
    > Change-Id: I0081f3938c56e2f24d8227e4640032749f4f8368
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1373782
    > Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#66239}
    
    TBR=rmcilroy@chromium.org,mstarzinger@chromium.org,neis@chromium.org,georgia.kouveli@arm.com
    
    Change-Id: I57d5928949b0d403774550b9bf7dc0b08ce4e703
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10026
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051952Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66242}
    6a9a67d9
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...