• Benedikt Meurer's avatar
    [ignition] Improve code generation for TestTypeOf. · 6a75fcd4
    Benedikt Meurer authored
    The code generated for the TestTypeOf bytecode was not ideal, mostly
    because of the default case that just aborted. If we do CSA_ASSERT to
    check the validity of the literal_flag instead anf then just use the
    last label as the default, the bytecode handler no longer builds a
    stack frame and generated code quality is now really close to ideal.
    
    The TestTypeOf bytecode handler was found to be among the three
    hottest bytecode handlers in the Speedometer/AngularJS benchmark.
    
    R=jarin@chromium.org
    
    Change-Id: I47705a0ca0a436d5c42899001064e77d44845a64
    Reviewed-on: https://chromium-review.googlesource.com/589207Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46930}
    6a75fcd4
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...