• Michael Lippautz's avatar
    cppgc: Fix marked bytes accounting for weak containers · 69be929b
    Michael Lippautz authored
    Conceptually, Oilpan uses tri-color marking even though the
    implementatin only uses a single mark bit. The difference between gray
    and black is represented by the fact that an objet is contained within
    a worklist.
    
    Live bytes are accounted on gray->black transition and must only
    happen once. This is generally implemented when retrieving an object
    from the work list and processing it.
    
    For weak containers this CL fixes the following issues:
    
    1. Weak containers that are strongified during stack scanning were
       double accounted as they were just added to the marking worklist.
       Instead, directly process them during stack scanning.
    2. Accounting was missing in case of purely weak collections without
       ephemeron tracing. In such a case, the backing store would not be
       added to a worklist and be considered as black immediately. The fix
       is to directly account the marked bytes in such a scenario.
    
    Bug: chromium:1056170
    Change-Id: I350ae1b90ad1753d024a3ce33fc3ec3126a2095d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2900661Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74629}
    69be929b
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...